feat(invitations): complete external ID bulk invite flow and redesign result dialog by LWS49 · Pull Request #8406 · Coursemology/coursemology2

LWS49 · 2026-05-26T07:35:38Z

Part 1: External ID in the invite flow

Summary

Completes the external ID bulk invite flow started in the previous PR. The CSV upload now acts as a full upsert for external IDs on existing records: a nil ext_id is filled in, a non-nil ext_id that differs from the CSV value is overwritten (not rejected), and a blank CSV cell preserves the existing value. The external_id_conflict error condition is removed - the only remaining hard rejection for ext_id is external_id_taken (the CSV value is already held by a different course member). Updated rows fold into the Existing Invitations and Existing Course Users sections with a bold ext_id badge and old-value tooltip; the separate "External IDs Updated" section is removed. Error messages in the controller are now per-error-type rather than a single sentence, enabling the result dialog to attribute each failure reason precisely. The external_id field is carried through to CourseUser on invitation acceptance. The score summary CSV download gains an opt-in ext_id column, shown only when at least one student has a non-blank ext_id.

Design decisions

Incoming available non-null external ID differing from user's current non-null ID treated as upsert, not error - CSV uploads are submitted exclusively by course staff (trusted actors). The real safety guard is external_id_taken (ID collision across different people), which is still a hard error. Flagging a staff member correcting a previous ext_id entry as a conflict imposes workflow cost with no safety gain. Nil-to-value and non-nil-to-different-value are now treated symmetrically.
Updated rows merged into existing sections - folding updated rows into Existing Invitations/Course Users with a bold ext_id badge and "Previously: X" tooltip is sufficient signal. A dedicated "External IDs Updated" section created a confusing fourth category; updated users are conceptually still existing users.
Failed section at top - rows in the Failed section require the admin to take action before re-uploading. Placing them below success sections risks the admin closing the dialog without noticing.
Save order: updated records before new records - within the transaction, updated invitations and course users are saved before new ones. This is required for freed-ID batch claims: if Alice changes from freed-id to new-id and Bob claims freed-id in the same batch, Alice's update must persist first so Bob's insert doesn't hit the unique constraint.
external_id coerced via .presence when building CourseUser from invitation - the partial unique index on course_users(course_id, external_id) only covers non-NULL values (WHERE external_id IS NOT NULL). Storing an empty string "" would subject it to the uniqueness constraint, causing duplicate-key errors when multiple invitees have no external ID set. .presence converts "" → nil, keeping those rows outside the partial index scope.
6-column CSV uploaded to a non-timeline course is rejected with an error toast - when show_personalized_timeline_features? is false, the parser reads row[4] as external_id. A 6-column file (the timeline template) would silently store the timeline string (e.g. "otot") as the external ID. Column count detection (row.length > 5) is used as the signal: value-matching against known algorithm names was rejected because those strings are valid external IDs. The upload is aborted before any row is processed and a descriptive toast tells staff to use the 5-column template.
DB user-object lookup runs before CSV external-ID dedup - previously, partition_unique_users (CSV dedup) ran before augment_user_objects (DB lookup), so the dedup had no way to know that a row belonged to an existing account. An enrolled user re-uploaded with their current external ID alongside a new user holding the same ID was incorrectly rejected as duplicate_external_id_in_file at the CSV phase, before the DB-aware process phase had a chance to recognise them as already enrolled. The fix moves the DB lookup first; partition_unique_users now receives the resolved existing_account_emails set and exempts those rows from external-ID dedup, leaving them for the process phase which handles them correctly.

Service behavior: master vs this PR

Ext_id is checked at four points in the service pipeline. @taken_external_ids is pre-loaded from both CourseUser and unconfirmed Course::UserInvitation ext_ids, so a conflict with either type anchors the same rejection.

Processing step	Master	This PR
New user (no account) - new invitation	No ext_id check - invitation always created	Checks `@taken_external_ids`; conflict - `external_id_taken` failure
Existing user (not yet in course) - new enrollment	No ext_id check - always enrolled	Same conflict check via `enroll_new_user`
Re-invite: existing pending invitation	ext_id field absent	Updates ext_id if free; conflict - `external_id_taken` failure
Re-invite: existing course member	ext_id field absent	Updates ext_id if free; conflict - `external_id_taken` failure
Enrolled user re-uploaded with their own current ext_id	Incorrectly rejected as `duplicate_external_id_in_file` when another CSV row holds the same ID	Recognised as existing enrolled member; new user with same ID fails `external_id_taken` instead
CSV email matches user with unconfirmed account	Treated as new user - invitation sent	Unchanged - unconfirmed account holders receive an invitation they can accept after confirming their email, not direct enrollment

Cross-type freed-ID ordering limitation

When an existing course user frees an ext_id and a brand-new user (no Coursemology account) claims it in the same batch, the new user is still rejected with external_id_taken. invite_new_users runs before add_existing_users in the pipeline, so the new invitation is evaluated before the existing course user releases the ID. The same-type freed-ID case (both are existing invitations, or both are course users) works correctly. The spec documents this behavior explicitly rather than asserting it should work - a two-pass fix would add complexity for a narrow edge case.

Regression prevention

Service specs cover: nil-to-value upsert for invitations and course users; non-nil-to-different-free-value upsert with previous_external_id capture; external_id_taken on new invitations, new enrollments (existing user not yet in course), existing invitation updates, and existing course user updates; conflict anchored by course user ext_id vs invitation ext_id; freed-ID batch claim within the same record type; cross-type freed-ID ordering limitation; unconfirmed-email path sends invitation not direct enrollment; isRetryable: false propagated through jbuilder; 6-column CSV uploaded to a non-timeline course raises CSV::MalformedCSVError (guards the silent-corruption path where timeline strings become external IDs); enrolled user re-uploaded with their own current external ID alongside a conflicting new user passes CSV dedup and reaches the process phase (reason is external_id_taken not duplicate_external_id_in_file); enrolled user re-uploaded with their own current external ID and no conflicting new user succeeds with no failures.

Model specs cover: blank external_id on invitation ("") produces nil on the built CourseUser — guards the .presence call in User#build_course_user_from_invitation against silent removal (empty string would otherwise pass the partial unique index's IS NOT NULL guard and cause duplicate-key errors).

Frontend specs cover: InvitationResultExistingTable updated-row rendering (bold + badge + tooltip); InvitationResultDialog - failed invitations in Failed section not Existing Invitations, failedRowsSubtitle shown only for failed_to_send rows with correct count, subtitle absent when only CSV-issue duplicates present, mixed-failure count correctly split between header and caption; InvitationResultFailedTable reason text for all four failure reasons.

Manual testing: happy path new batch; nil-to-value upsert with badge; non-nil-to-different upsert with tooltip; external_id_taken in Failed section; freed-ID same-type batch; existing user no-change; failed-to-send rows in red with caption; CSV-issue rows without caption; mixed failure section showing correct split counts.

Backward compatibility: existing invite flows unaffected. The only behavioral change for existing data is that re-inviting a user whose ext_id differs from the CSV value now updates the record instead of rejecting it.

Part 2: Independent improvements

Summary

Five fixes made to the invite flow independent of the external ID feature.

First, invitations with is_retryable: false (permanent email delivery failures) were previously indistinguishable from normal pending invitations in the Existing Invitations section; they are now routed to a dedicated Failed section, highlighted in red, with a caption identifying exactly which rows could not be sent.

Second, UserInvitationsTable had two related fixes: it was importing getManageCourseUserPermissions from course/users/selectors (reads state.users) instead of the invitations store (state.invitations), causing the Personalized Timeline column to flicker on SPA navigation; and the column gate was changed from canManagePersonalTimes to showPersonalizedTimelineFeatures for correctness (see design decisions below).

Third, a conditional "Personalized Timeline" column is added to all three invitation result tables (new invitations/enrollments, existing, and failures). The column appears only when showPersonalizedTimelineFeatures is enabled. timeline_algorithm is now serialized on all seven record sections in the result data; the flag is added to the invitation index response, stored in Redux alongside defaultTimelineAlgorithm (and added to the initial state of all three bundles that share ManageCourseUsersSharedData: invitations, users, and enrol-requests), read by InvitationResultDialog, and threaded to each table component.

Fourth, build_course_user in the invitation service was ignoring the CSV timeline_algorithm column for directly-enrolled existing users and always assigning the course default instead. The fix passes user[:timeline_algorithm] through, consistent with build_invitation and build_course_user_from_invitation. build_course_user_from_invitation in User also had .presence added to external_id for consistency with user_registration_service.

Fifth, stale naming is cleaned up throughout the course bundle (service, controller, jbuilder, types, components, specs; instance bundle unchanged): InvitationResultUsersTable → InvitationResultFailedTable, InvitationResultSkippedTable → InvitationResultExistingTable (with its exported row type SkippedRow → ExistingRow), DuplicateUserData → FailedInvitationRowData, and duplicate_users / duplicateUsers → failed_users / failedUsers.

Design decisions

is_retryable: false invitations excluded from the "already invited" summary count - permanently failed invitations are not in the course and will never arrive; counting them as "already invited" misleads the admin into thinking those users are handled.
Timeline column gate: canManagePersonalTimes preserved for editable inputs, showPersonalizedTimelineFeatures used for read-only display - these two flags are related but distinct. canManagePersonalTimes is the compound show_personalized_timeline_features? && can?(:manage_personal_times) — it requires both the course feature to be on and the user to hold the manage permission. The invite forms and CSV upload (unchanged from master) correctly gate on canManagePersonalTimes: showing an editable timeline field only makes sense when the user can actually set it. The live invitations table (UserInvitationsTable) and the result tables are read-only display — the column should be visible to anyone who can see the page whenever the course feature is on, regardless of whether they hold the manage permission. UserInvitationsTable previously used canManagePersonalTimes (same as the forms); this PR corrects it to showPersonalizedTimelineFeatures to match the result tables. The result tables are new and use showPersonalizedTimelineFeatures from the start.

Regression prevention

Service specs cover:

build_course_user assigns the CSV timeline_algorithm to the enrolled CourseUser, not the course default (regression guard for the ignored-column bug).

Frontend specs cover:

InvitationsIndex - Personalized Timeline column appears when showPersonalizedTimelineFeatures is true in the API response (seeded into state.invitations) and is absent when false, with state.users unpopulated in both cases (regression guard for the wrong-store import and the gate change from canManagePersonalTimes to showPersonalizedTimelineFeatures).
column shown with correct algorithm label when showPersonalizedTimelineFeatures is true, column absent when false, dash rendered when timelineAlgorithm is undefined - for each of InvitationResultPrimaryTable, InvitationResultExistingTable, and InvitationResultFailedTable. InvitationResultDialog integration tests verify the flag is read from the Redux store and threads to tables (column visible with showPersonalizedTimelineFeatures: true in store, hidden with default store).

Manual testing: is_retryable: false invitations appear in Failed section highlighted in red; Personalized Timeline column visible on both SPA navigation and hard refresh when personalized timelines enabled, absent in both when disabled.

Backward compatibility: invite forms and CSV upload gate unchanged (canManagePersonalTimes). Result dialog unchanged for courses with Personalized Timelines disabled.

Current Result Display

Happy Path

All Failure Reasons Shown

Timelines Shown In Table If Enabled

Error Flagged if CSV with >5 Columns Used with Timelines Off

adi-herwana-nus · 2026-06-03T04:37:48Z

+import tableTranslations from 'lib/translations/table';
+
+const translations = defineMessages({
+  yes: {


Can we use lib.translations.yes here? (and for no)

Fixed in ExistingTable, FailedTable, and PrimaryTable — all three now import and use libTranslations.yes / libTranslations.no from lib/translations.

adi-herwana-nus · 2026-06-03T04:38:22Z

+    defaultMessage:
+      'Failed to send invitation email, please try again - if failures persist, contact us for assistance',
+  },
+  yes: {


same here, let's use lib.translations.yes to minimize unneccesary duplication

Fixed — same as above, using libTranslations now.

adi-herwana-nus · 2026-06-03T04:47:32Z

-    query = Course::UserInvitation.unconfirmed.where(course_id: course_id, external_id: external_id)
-    query = query.where.not(id: id) if is_a?(Course::UserInvitation)
-    query.exists?
+    scope = Course::UserInvitation.unconfirmed.where(course_id: course_id, external_id: external_id)


I think this change is unneccessary, query was a perfectly fine variable name before. I feel semantic-only changes only add noise to the blame history.

Reverted to query.

adi-herwana-nus · 2026-06-03T04:49:17Z

  def parse_file_row(row)
    return nil if row[1].blank?

+    if !@current_course.show_personalized_timeline_features? && row.length > 5


Part of me feels like there should be an analogous check for when personalized timelines is enabled.

On reflection, the analogous check (timelines enabled, fewer than 6 columns) isn't meaningful to add. A row with as few as 2 columns is valid - role, phantom, timeline algorithm, and external ID all have sensible defaults, so a short row is not an error worth raising. A "too many columns" check in the other direction similarly serves no purpose here.

More broadly, this check is a temporary gap-stopper: #8427 replaces it with proper header-based validation, which handles both directions correctly. Given its short lifespan, keeping the current check narrow feels appropriate.

Copilot

Pull request overview

Completes the bulk-invite “external ID” upsert flow in the backend service and updates the frontend invitation result UX to accurately report failures/updates (including Personalized Timeline display) while simplifying result categorization.

Changes:

Extend Course::UserInvitationService to support external ID upserts on existing invitations/course users, track update metadata, and replace duplicate_users with failed_users.
Redesign the invitation result dialog into primary/existing/failed tables, add updated-row highlighting + tooltips, and show Personalized Timeline column based on showPersonalizedTimelineFeatures.
Add guards + messaging for CSV template mismatch (6-column upload when timelines are disabled), and extend tests/specs accordingly.

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
spec/services/course/user_invitation_service_spec.rb	Updates/extends service specs for failed users, ext_id upsert, CSV mismatch, and timeline assignment behavior.
spec/models/user_spec.rb	Adds regression spec for blank invitation `external_id` coercing to `nil` on built `CourseUser`.
spec/models/course_user_spec.rb	Adds regression coverage for external_id uniqueness vs pending invitations (including update/id edge case).
spec/controllers/course/user_invitations_controller_spec.rb	Ensures `isRetryable` is included in `existingInvitations` result payload.
config/locales/zh/errors.yml	Adds timeline template mismatch error message (Chinese).
config/locales/zh/csv.yml	Improves Chinese CSV header translations (“Email”/role wording).
config/locales/ko/errors.yml	Adds timeline template mismatch error message (Korean).
config/locales/en/errors.yml	Adds timeline template mismatch error message (English).
client/locales/zh.json	Updates invitation-result + failed-table translations (Chinese).
client/locales/ko.json	Updates invitation-result + failed-table translations (Korean).
client/locales/en.json	Updates invitation-result + failed-table translations (English).
client/app/types/course/userInvitations.ts	Renames/reshapes result payload types (`failedUsers`, updated items, reasons).
client/app/types/course/courseUsers.ts	Adds `showPersonalizedTimelineFeatures` to shared manage-users data type.
client/app/bundles/course/user-invitations/store.ts	Seeds `showPersonalizedTimelineFeatures` into invitations bundle initial state.
client/app/bundles/course/user-invitations/pages/InviteUsersFileUpload/index.tsx	Updates external ID help text to reflect overwrite/upsert semantics.
client/app/bundles/course/user-invitations/pages/InvitationsIndex/test/index.test.tsx	Adds frontend regression tests for timeline column gating + correct store selector usage.
client/app/bundles/course/user-invitations/components/tables/UserInvitationsTable.tsx	Fixes selector import and gates timeline column on course feature flag (not permission).
client/app/bundles/course/user-invitations/components/tables/InvitationResultUsersTable.tsx	Removes legacy “users result” table (replaced by new tables).
client/app/bundles/course/user-invitations/components/tables/InvitationResultPrimaryTable.tsx	New table for successful rows (new invitations/enrollments), with optional timeline column + CSV download.
client/app/bundles/course/user-invitations/components/tables/InvitationResultInvitationsTable.tsx	Removes legacy “invitations result” table (replaced by new tables).
client/app/bundles/course/user-invitations/components/tables/InvitationResultFailedTable.tsx	New failed rows table (reason mapping + red highlighting for `failed_to_send`).
client/app/bundles/course/user-invitations/components/tables/InvitationResultExistingTable.tsx	New existing/updated rows table (update highlighting + “Previously” tooltip).
client/app/bundles/course/user-invitations/components/tables/test/InvitationResultPrimaryTable.test.tsx	Unit tests for primary table columns, timeline gating, and ext_id column behavior.
client/app/bundles/course/user-invitations/components/tables/test/InvitationResultFailedTable.test.tsx	Unit tests for failed table reasons, highlighting, and timeline gating.
client/app/bundles/course/user-invitations/components/tables/test/InvitationResultExistingTable.test.tsx	Unit tests for existing table ordering, tooltip behavior, highlighting, and timeline gating.
client/app/bundles/course/user-invitations/components/misc/InvitationResultDialog.tsx	Rebuilds dialog summary + sections, consolidates failures, and threads timeline feature flag from store.
client/app/bundles/course/user-invitations/components/misc/test/InvitationResultDialog.test.tsx	Integration tests for section routing, counts, ordering, and timeline column visibility via store.
client/app/bundles/course/enrol-requests/store.ts	Seeds `showPersonalizedTimelineFeatures` into enrol-requests bundle initial state.
app/views/course/user_invitations/index.json.jbuilder	Exposes `showPersonalizedTimelineFeatures` in shared manage-users data.
app/views/course/user_invitations/_invitation_result_data.json.jbuilder	Serializes timeline algorithm, retryability, failed users, and updated items into result payload.
app/services/course/user_invitation_service.rb	Expands service return tuple, saves updated records before inserts, and renames duplicate→failed tracking.
app/services/course/statistics/assessments_score_summary_download_service.rb	Uses `.presence` for external_id CSV column output.
app/services/concerns/course/user_invitation_service/process_invitation_concern.rb	Implements ext_id upsert for existing invitations/course users + timeline_algorithm direct-enrollment fix.
app/services/concerns/course/user_invitation_service/parse_invitation_concern.rb	Detects 6-column CSV mismatch when timelines are off and normalizes duplicate rows into failed_users.
app/models/user.rb	Coerces invitation `external_id` via `.presence` when building `CourseUser`.
app/models/concerns/course/unique_external_id_concern.rb	Refactors uniqueness checks to avoid incorrect invitation exclusion logic.
app/controllers/course/user_invitations_controller.rb	Updates result renderer signature to include failed + updated collections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

LWS49 · 2026-06-04T15:00:55Z

+json.failedUsers failed_users.each.with_index do |failed_user, index|
  json.id index
-  json.name duplicate_user[:name]
-  json.email duplicate_user[:email]
-  json.externalId duplicate_user[:external_id]
-  json.role duplicate_user[:role]
-  json.phantom duplicate_user[:phantom]
-  json.reason duplicate_user[:reason]
+  json.name failed_user[:name]


Updated — entries with a real DB id (e.g. AR-backed records pushed with external_id_taken) now keep their own id; hash-only entries fall back to -(index + 1).

LWS49 · 2026-06-04T13:53:27Z

+  previouslyLabel: {
+    id: 'course.userInvitations.InvitationResultExistingTable.previouslyLabel',
+    defaultMessage: 'Previously: {value}',
+  },


Fixed — added course.userInvitations.InvitationResultExistingTable.previouslyLabel to en.json, zh.json, and ko.json.

LWS49 · 2026-06-04T13:53:29Z

+  "course.userInvitations.InvitationResultFailedTable.externalIdTakenEnrolled": {
+    "defaultMessage": "已是课程成员 — 外部编号未能应用（已分配给另一名成员"
+  },


Fixed — added the missing closing ）.

LWS49 · 2026-06-04T13:53:30Z

        invalid_email: '%{email} could not be processed: invalid email: %{message}.'
        duplicate_external_id: '%{email} could not be processed: external ID "%{external_id}" is already taken.'
        other_error: '%{email} could not be processed: %{message}.'
+        timeline_template_mismatch: 'more than 5 columns detected. This course does not use Personalized Timelines. Please re-upload using the 5-column template (Name, Email, Role, Phantom, External ID).'


Fixed — capitalised.

LWS49 · 2026-06-04T13:53:33Z

  # @param [Array<Hash>|File|TempFile] users Invites the given users.
-  # @return [Array<Integer>|nil] An array containing the the size of new_invitations, existing_invitations,
-  #   new_course_users and existing_course_users, duplicate_users respectively if success. nil when fail.
+  # @return [Array<Integer>|nil] An array containing the size of new_invitations, existing_invitations,
+  #   new_course_users, existing_course_users, failed_users, updated_invitations, updated_course_users
+  #   respectively if success. nil when fail.


Fixed — docstring now says the method returns the seven arrays, not their sizes.

LWS49 · 2026-06-04T13:53:35Z

+  "course.userInvitations.InvitationResultDialog.summaryFailed": {
+    "defaultMessage": "{count}건이 실패했습니다."
+  },
+  "course.userInvitations.InvitationResultDialog.updatedSubtitle": {
+    "defaultMessage": "{count}개 업데이트됨 · 먼저 표시"
+  },


Fixed — added summary and failedRowsSubtitle to ko.json.

LWS49 · 2026-06-04T13:53:37Z

+  "course.userInvitations.InvitationResultDialog.summaryFailed": {
+    "defaultMessage": "{count} 个失败。"
  },
-  "course.userInvitations.InvitationResultUsersTable.duplicateExternalIdInFile": {
+  "course.userInvitations.InvitationResultDialog.updatedSubtitle": {
+    "defaultMessage": "{count} 条已更新 · 优先显示"
+  },


Fixed — added summary and failedRowsSubtitle to zh.json.

… dialog - add ext_id to CourseUser and UserInvitation with unique-per-course index - accept ext_id in bulk CSV and individual invite form; upsert for existing records (enrolled users and pending invitations) - conflicts (duplicate email or ext_id) surface in Failed with reasons

…led user to fall under Failed instead of Existing

LWS49 changed the base branch from master to lws49/feat-add-ext-id May 26, 2026 07:36

LWS49 changed the title ~~feat(invitations): complete external ID bulk invite flow~~ feat(invitations): complete external ID bulk invite flow and redesign result dialog May 26, 2026

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 4 times, most recently from c0dcc05 to e892fd9 Compare May 26, 2026 15:12

LWS49 force-pushed the lws49/feat-add-ext-id branch from d6e1808 to b75a804 Compare May 28, 2026 00:47

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 7 times, most recently from a037a06 to 023720d Compare May 28, 2026 09:41

LWS49 force-pushed the lws49/feat-add-ext-id branch 2 times, most recently from 9c8e986 to 007edda Compare May 29, 2026 06:45

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 3 times, most recently from 0ef7442 to 62635b4 Compare May 29, 2026 08:47

LWS49 marked this pull request as ready for review May 29, 2026 08:56

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch from 62635b4 to ba302dd Compare June 1, 2026 10:17

LWS49 force-pushed the lws49/feat-add-ext-id branch 3 times, most recently from 6226857 to 9c27231 Compare June 2, 2026 00:59

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 6 times, most recently from d83d859 to 4087560 Compare June 2, 2026 07:26

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 2 times, most recently from 06af4fa to ae12c5e Compare June 2, 2026 09:28

LWS49 force-pushed the lws49/feat-add-ext-id branch 5 times, most recently from 3498902 to 9c390c4 Compare June 2, 2026 16:48

Base automatically changed from lws49/feat-add-ext-id to master June 2, 2026 17:28

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 3 times, most recently from 309b762 to 85a592d Compare June 3, 2026 03:19

LWS49 marked this pull request as draft June 3, 2026 03:54

adi-herwana-nus reviewed Jun 3, 2026

View reviewed changes

adi-herwana-nus requested a review from Copilot June 3, 2026 04:47

Copilot started reviewing on behalf of adi-herwana-nus June 3, 2026 04:47 View session

adi-herwana-nus reviewed Jun 3, 2026

View reviewed changes

Copilot AI reviewed Jun 3, 2026

View reviewed changes

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 4 times, most recently from 23c59ca to 559264e Compare June 4, 2026 15:16

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch from 546aed9 to b379882 Compare June 4, 2026 15:24

LWS49 marked this pull request as ready for review June 4, 2026 15:35

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch 2 times, most recently from 8ed6794 to db90f87 Compare June 4, 2026 16:14

fix(invitations): fix bug where dupe external ID in file causes enrol…

b761414

…led user to fall under Failed instead of Existing

LWS49 force-pushed the lws49/feat-ext-id-invite-flow branch from db90f87 to b761414 Compare June 4, 2026 16:18

Conversation

LWS49 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Part 1: External ID in the invite flow

Summary

Design decisions

Service behavior: master vs this PR

Cross-type freed-ID ordering limitation

Regression prevention

Part 2: Independent improvements

Summary

Design decisions

Regression prevention

Current Result Display

Happy Path

All Failure Reasons Shown

Timelines Shown In Table If Enabled

Error Flagged if CSV with >5 Columns Used with Timelines Off

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LWS49 Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LWS49 commented May 26, 2026 •

edited

Loading

LWS49 Jun 4, 2026 •

edited

Loading